Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhysicalConsole: Fix UTF-8 related failure #1879

Closed
wants to merge 2 commits into from
Closed

PhysicalConsole: Fix UTF-8 related failure #1879

wants to merge 2 commits into from

Conversation

zmc
Copy link
Member

@zmc zmc commented Aug 2, 2023 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/62286

@dmick, I'm not sure if this was your intent, but we're logging a lot more now after #1869. For example:

$ grep -a -A1 "console.*\(expect before\|output\):" /a/zack-2023-08-02_18:04:55-powercycle-reef-distro-default-smithi/7358307/teuthology.log > /tmp/7358307_console.txt
$ wc -l /tmp/7358307_console.txt
76 /tmp/7358307_console.txt
$ wc -c /tmp/7358307_console.txt
53344 /tmp/7358307_console.txt53344

@zmc zmc requested a review from dmick August 2, 2023 18:54
@zmc
Copy link
Member Author

zmc commented Aug 2, 2023

https://pulpito-ng.ceph.com/runs/zack-2023-08-02_18:04:55-powercycle-reef-distro-default-smithi

@zmc
Copy link
Member Author

zmc commented Aug 2, 2023

I just noticed I used the wrong tracker ID in the commit and the branch. I'm going to re-file this.

@zmc zmc closed this Aug 2, 2023
@zmc zmc mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriw yuriw yuriw approved these changes

@dmick dmick Awaiting requested review from dmick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmc @yuriw